Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/FP-119: Allow list of parameters #674

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

duckonomy
Copy link
Contributor

@duckonomy duckonomy commented Jul 13, 2022

Overview

Add parameter list forms for the Application Forms.

Related

Changes

Added a multi input formfield that sees the maxCardinality and minCardinality of an app and it's definition.
It should return an array value for the resulting output.

Testing

  1. Test with Test Arrays! Application in My Apps (Shared app with user ids stijerina and edmondsgarrett)
  2. Ensure that you can see and use the multi input interface.
  3. Ensure that you cannot remove a form if it's less than or equal to the minCardinality.
  4. Ensure that you cannot add more forms if it has a count greater than equal to the maxCardinality.
  5. Ensure that validation works.

UI

Screen Shot 2022-08-25 at 5 20 34 PM

Notes

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #674 (92de361) into main (d7ebf2c) will decrease coverage by 0.49%.
The diff coverage is 23.61%.

❗ Current head 92de361 differs from pull request most recent head b56de00. Consider uploading reports for the commit b56de00 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
- Coverage   68.50%   68.00%   -0.50%     
==========================================
  Files         222      222              
  Lines        6051     6105      +54     
  Branches     1695     1729      +34     
==========================================
+ Hits         4145     4152       +7     
- Misses       1831     1872      +41     
- Partials       75       81       +6     
Flag Coverage Δ
javascript 68.00% <23.61%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/src/components/_common/Form/FormField.jsx 57.14% <13.79%> (-27.18%) ⬇️
...c/components/Applications/AppForm/AppFormSchema.js 54.28% <30.23%> (-11.95%) ⬇️

@duckonomy duckonomy marked this pull request as ready for review July 14, 2022 19:59
@duckonomy duckonomy marked this pull request as draft July 26, 2022 17:25
@rstijerina rstijerina changed the title Task/FP-119: Allow list of parameters task/FP-119: Allow list of parameters Aug 16, 2022
…om/tacc/core-portal into task/FP-119-allow-list-of-parameters
@duckonomy duckonomy marked this pull request as ready for review August 25, 2022 22:21
@duckonomy duckonomy marked this pull request as draft November 15, 2022 16:21
@jmartinez-tacc jmartinez-tacc deleted the task/FP-119-allow-list-of-parameters branch January 11, 2023 17:16
@rstijerina rstijerina restored the task/FP-119-allow-list-of-parameters branch January 11, 2023 17:28
@rstijerina rstijerina reopened this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants