FP-1318: Create Section Pattern via Bootstrap Container Plugin

[wesleyboar]

To Do

• install django-cms/djangocms-bootstrap4 at v3.0.0
• re-test
• fix django cms error upon adding container
• ping reviewers

Overview

Quickly create existing TACC Section pattern via already-installed¹ Django Bootstrap4 Container plugin.

CMS Admin/Designer has approved (via private review), but implementation needs dev review.

Tickets

• FP-1318 → FP-1478

Changes

To our default settings:

• Add DJANGOCMS_BOOTSTRAP4_GRID_CONTAINERS (docs).
  • to allow user to quickly create light Section or dark Section (as Container or not)
• (Optional) Load gettext_lazy.
  • to support translation of choice group labels and values²

To our default requirements:

• Install fork of djangocms-bootstrap4 that has approved fix.
  • to fix minor UI bug where Container plugin has blank short description for grouped choices²

Screenshots

FP-1318.Section.Pattern.via.Container.Plugin.mov

Testing

local: instructions
remote: https://dev.cep.tacc.utexas.edu/ (build, deploy)

1. On any page, create a Container plugin.
2. Choose some of the eight CONTAINER TYPEs.
3. Confirm an element is added each time with the appropriate class attribute.*

* To see what the section should look like, you may compare to manual pattern library.

Notes

Related PRs

• Use Style Plugin Instead & Define Tag Types:
  FP-1318: Create Section Pattern via Style Plugin #430
• Use Style Plugin Instead & Support Other Classes:
  FP-1414: More Classnames for Django CMS Style Plugin #419

Footnotes

1. The install is given a new requirement (in requirements.txt) to fix a minor UI bug. ↩

2. I.e. <optgroup> labels and <option> values in selection dropdown when DJANGOCMS_BOOTSTRAP4_GRID_CONTAINERS has nested tuples. ↩ ↩²

[rstijerina]

Nice work on the PR to django-cms! Do we have an idea of when it will be merged?

[wesleyboar]

Thank you.

We do not have an idea. I'll update here if I learn.

I've asked for the status on that PR and been watching the DjangoCMS Slack channel. Earlier this month, the team (and that PR's approver) had a heavy PR load so I haven't poked anyone. (But I have watched how others poke, so I can be ready to.)

[wesleyboar]

@rstijerina I still have not received a reply to my inquiry of when DjangoCMS Bootstrap4's PR would get merged.

So, I've pinged 'em in their Slack channel, just now.

[taoteg]

Works as described. Great job!

[wesleyboar]

Thanks, @taoteg!

I'm holding off on merging this to see if Django CMS will merge my fix to their code this spring, so we need not point to and maintain my fork.

[wesleyboar]

Progress on the Django CMS PR: The approving reviewer pinged for others to double-check (Slack).

[wesleyboar]

I pinged them again (Slack).

[wesleyboar]

I may need to test their changes to get it merged.

[wesleyboar]

2nd reviewer claims he has comments for me. But I can't find them. While manually testing in isolation, I found two issues and noted them in the PR description.

I don't have the bandwidth to tend to it anymore right now.

[wesleyboar]

Progress. It's on me again. Gotta add test cases for code coverage on plugin PR. Done enough today, though.

[wesleyboar]

The PR from my fork is merged upstream! I updated this PR to install at the latest commit of the plugin's main branch, which is 13 commits (over two years) ahead of 2.0.0. I'll wait a month to see if they cut a new release. if not, I'll retest and ping for review.

[wesleyboar]

All right, I want new-to-foss bragging rights for having several commits in django-cms/djangocms-bootstrap4 v3.0.0.

I'll update this PR to v3.0.0 and test when I get a chance.

[wesleyboar]

Suggested change

	djangocms-bootstrap4 = {
	git = "https://github.com/django-cms/djangocms-bootstrap4.git",
	rev = "7543e87" # 13 commits (over two years) since 2.0.0
	}
	djangocms-bootstrap4 = "3.0.0"

[wesleyboar]

Important
Still useful. Simpler diff. But bug since using djangocms-bootstrap4 v3.0.0 + main.