Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to specify a non-default classloader for the annotation frame factory #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsight
Copy link
Contributor

@jsight jsight commented Jan 8, 2018

This is really still not sufficient for our use case, as we also rely on the typemanager being able to return multiple interface classes.

I wonder if that is something that we could integrate into upstream later on? Perhaps we can talk about it more?

@codecov
Copy link

codecov bot commented Jan 8, 2018

Codecov Report

Merging #42 into master will decrease coverage by 0.08%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #42      +/-   ##
============================================
- Coverage     84.86%   84.77%   -0.09%     
- Complexity      452      453       +1     
============================================
  Files            31       31              
  Lines          1407     1412       +5     
  Branches        283      283              
============================================
+ Hits           1194     1197       +3     
- Misses           70       72       +2     
  Partials        143      143
Impacted Files Coverage Δ Complexity Δ
...mefactories/annotation/AnnotationFrameFactory.java 70% <0%> (-7.78%) 2 <0> (ø)
...ies/annotation/AbstractAnnotationFrameFactory.java 97.95% <100%> (+0.13%) 22 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc3931...2fa89b6. Read the comment docs.

@freemo
Copy link
Member

freemo commented Jan 16, 2018

@jsight Hey, things calmed down here and im going through your PR. Can you stop by gitter so we can chat about your use case before I make a decision on merging?

@jsight
Copy link
Contributor Author

jsight commented Jan 17, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants