Contribution: fetchBalance() from Trading Session #5131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awhiteweb
requested changes
Apr 16, 2024
| async function fetchAllBalances() { | ||
| // Validations: | ||
| if (exchange.has['fetchBalance'] === false) { | ||
| logError("fetchAllBalances -> Exchange does not support fetchBalance command."); |
There was a problem hiding this comment.
This if statement needs to return false, otherwise it will try and run the next statement.
| } | ||
| try { | ||
| let balances = await exchange.fetchBalance(); | ||
| console.log(' -> Succesfully executed "fetchBalance" and retrieved actual account balances from the exchange.') |
There was a problem hiding this comment.
Please change to use the SA.logger.info call instead of console.log
| if (tradingEngine.tradingCurrent.tradingEpisode.userDefinedVariables.userDefinedVariable[0].value === 0) { | ||
| tradingEngine.tradingCurrent.tradingEpisode.userDefinedVariables.userDefinedVariable[0] = [] | ||
| tradingEngine.tradingCurrent.tradingEpisode.userDefinedVariables.userDefinedVariable[0][0] = balances | ||
| console.log(' -> Stored INITIAL raw data from fetchBalance() at userDefinedVariable[0][0]') |
There was a problem hiding this comment.
Change to use SA.logger.info
| console.log(' -> Stored INITIAL raw data from fetchBalance() at userDefinedVariable[0][0]') | ||
| } | ||
| tradingEngine.tradingCurrent.tradingEpisode.userDefinedVariables.userDefinedVariable[0][1] = balances | ||
| console.log(' -> Stored CURRENT raw data from fetchBalance() at userDefinedVariable[0][1]') |
There was a problem hiding this comment.
Change to use SA.logger.info
...ts/Algorithmic-Trading/TS/Bot-Modules/Trading-Bot/Low-Frequency-Trading/TradingSimulation.js
Outdated
Show resolved
Hide resolved
Awhiteweb
requested changes
Apr 22, 2024
| exchangeAPIModuleObject.initialize() | ||
| balances = await exchangeAPIModuleObject.fetchAllBalances() | ||
|
|
||
| if (balances !== undefined || balances !== false) { |
There was a problem hiding this comment.
Replace || with && as you want both conditions to be true to enter the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.