Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve wificfg #732

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve wificfg #732

wants to merge 4 commits into from

Commits on Oct 3, 2019

  1. extras/wificfg: make sure wificfg.h #includes all necessary files 

    Without these, wificfg.h can fail to compile because types like uint32_t,
size_t or ssize_t are not available.
    @zub2
    zub2 committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    58b9932 View commit details
    Browse the repository at this point in the history

  2. extras/wificfg: use #if when checking for configUSE_TRACE_FACILITY 

    FreeRTOS/Source/include/FreeRTOSConfig.h makes sure configUSE_TRACE_FACILITY
is always defined. But it's defined to 0 when TRACE_FACILITY is disabled.

When #ifdef is used, the guarded blocks of code are always compiled and
this results in link failure when TRACE_FACILITY is in fact not enabled.
    @zub2
    zub2 committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    5f6ccbd View commit details
    Browse the repository at this point in the history

  3. extras/wificfg: make the default wifi options overridable 

    wificfg.c defines the default values for ssid, password and hostname. But
because these are not weak, trying to redefine these causes a link error.

This change marks the definitions in wificfg.c weak, thus making it
possible for a program using the wificfg component to redefine these w/o
having to touch wificfg.c.
    @zub2
    zub2 committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    77b2b23 View commit details
    Browse the repository at this point in the history

  4. extras/wificfg: fix a typo in comment

    @zub2
    zub2 committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    a4defa3 View commit details
    Browse the repository at this point in the history