Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash size as megabytes #536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ckerkhoff
Copy link

When building I noticed the warning, "WARNING: Flash size arguments in megabits like '16m' are deprecated." This should take care of that.

@ckerkhoff
Copy link
Author

It looks like the CI build server is using a esptool version older than Aug 28 2016, which is when they started accepting megabytes for the flash size argument.

@nochkin
Copy link
Contributor

nochkin commented Jan 5, 2018

The esptool is a part of esp-open-sdk which is being built for esp-open-rtos:
https://github.com/SuperHouse/esp-open-rtos/blob/master/utils/travis_build/install_toolchain.sh
In order to support your patch, esp-open-sdk needs esptool updated.

P.S.: I'm using external esptool which supports the appropriate arguments. The same way as you do probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants