Modifying FitReadRadarScan to store sky noise in RadarBeam structure rather than search noise #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rather than search noise (which is not used by all radars)
…ng a few formatting errors
|
I've also just updated the online documentation to more clearly state that the noise values recorded in grid and map files originate from the sky noise parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses one issue recently raised in #570, where the fitted sky noise value is now used instead of the
search.noiseparameter to populate thenoisefields in grid and map files. You can test this by comparing noise values in grid files for different radars (some of which calculate search noise differently or not at all).