Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying RadarParmDecode to set ifmode to zero by default #594

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

egthomas
Copy link
Member

@egthomas egthomas commented Sep 12, 2023

This pull request addresses an inconsistency identified by Sessai, where currently the RadarParmDecode function sets the ifmode field to -1 if the field is not present, eg for files written by QNX4-era (or earlier) radars. This pull request modifies the behavior such that the ifmode field is always set to zero (0) by default (which matches our documentation).

To test, you can try something like this:

make_fit -fitacf2 20230129.0616.03.sys.rawacf > 20230129.0616.03.sys.fitacf
dmapdump 20230129.0616.03.sys.fitacf > 20230129.0616.03.sys.fitacf.dump
grep -r "ifmode" 20230129.0616.03.sys.fitacf.dump | tail -1

On this branch, the ifmode field in the radar parameter block should be 0, while on develop it will be -1. No other functionality has changed.

…e field is not present, eg for QNX4-era (or earlier) radars
@egthomas egthomas changed the title Modifying RadarParmDecode to set ifmode to zero Modifying RadarParmDecode to set ifmode to zero by default Sep 12, 2023
@ksterne ksterne added this to the RST 5.1 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants