-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elevation statistics tool #574
Conversation
Added a function to count the number of elevation angles with potentially valid values in fit-esque files.
Added a header for elevation angle statistical functions.
Created documentation for the elvstat functions.
Created a tool to print the number of potentially valid elevation angles in fit-esque file(s).
Free the `dnames` pointer once it's no longer used.
Sorry it's taken a bit! This is a nice feature to add in and I got the binary to work fairly easily. I had a few general comments or questions that aren't specific to any line so I thought I would post them here. Feel free to point me to a line in the code of somewhere that is relevant though. First, are you able to easily add in some info for the Second and much more minorly, I wasn't able to reproduce the results for the |
@aburrell, giving this a bump to see if you're able to add in a few things, mostly the results for the |
Hey @aburrell, do you think you'll be able to check this out? If you don't think you'll be able to look at adding |
Not a problem! I'm certainly patient on this, especially since it took my several months to initially review it. Just trying to put it at the top of the e-mail to try to get attention. But I understand there can be hotter burning fires that need to be put out, especially after being on travel. |
Hey @ksterne, I am now back from Japan and recovered from COVID. Unfortunately that means I have a bunch of stuff to catch up on. I will try to get to this in a week or so. |
@aburrell this looks good to me - I just added an XML documentation file so that |
Thanks @egthomas this looks good to me! |
@egthomas if I remember correctly, I am not supposed to merge this. Correct? |
It looks like there is another reviewer, Kevin. |
Created a tool to count the number of elevation angle observations with potentially realistic values. To test, try a radar that has and another that doesn't have elevation angles. This, unfortunately, doesn't identify garbage values that are within a potentially realistic range.
find_elvstat 20000131.2200.00.hal.fitacf3
Yields:
While
find_elvstat ~/Programs/Data/SuperDARN/Downloads/20170105.1001.00.lyr.fitacf3
Yields: