Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken HTML documentation links #559

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

egthomas
Copy link
Member

This pull request fixes the few remaining broken links in the HTML documentation - no code functionality is modified.

@ksterne
Copy link
Contributor

ksterne commented Mar 24, 2023

While testing this, I'm reminded of what we brought up in #532. In theory we probably shouldn't making updates to something we're deprecating, but the complete removal can happen in another PR. It's good to correct the issue so that it's right somewhere in the git history.

Agreed that this doesn't break compilation. I didn't initially look at the changes close enough to realize the fix to the broken link was to just remove any of the links. Does the rplot documentation not exist anymore? I'm sorry if I'm forgetting something, but I also didn't find any discussion or PR on it when searching this repo. It's OK if the documentation doesn't exist, just was surprised that they didn't exist at all.

@egthomas
Copy link
Member Author

egthomas commented Apr 3, 2023

Does the rplot documentation not exist anymore?

No, rplot was from the pre-3.x era of RST and from what I can tell it evolved into other libraries such as grplot, which has no documentation (and probably never will).

@ksterne ksterne added this to the RST 5.1 milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants