-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: Axes handling for projections - new geomagnetic zoomable plotting #382
Open
carleyjmartin
wants to merge
10
commits into
develop
Choose a base branch
from
ref/axes
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carleyjmartin
requested review from
bharatreddy,
Shirling-VT,
shibaji7,
Doreban,
billetd,
hiyadutuje,
RemingtonRohel,
KhanalKrishna and
PrestonXPitzer
May 15, 2024 18:28
Excellent! Thanks @KhanalKrishna ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
This PR amends some details in the projections module, updates the geographic plotting to allow the user to zoom in on areas and move the focus of the plot. A new projection is also made for the same thing in geomagnetic/MLT coordinates.
I was unable to allow subplot usage with these plots - the projections are very specific for use with SuperDARN data so I don't recommend making your own axes to put in, it would be nice to have the ability to plot multiple plots on one figure, but that will require a lot of work that I can't do right now.
Whats new:
issue: to close #357
Approval
Number of approvals: 2 at least please, lots of things to test
Test
matplotlib version: 3.8.2
Note testers: please indicate what version of matplotlib you are using
Also test with southern hemisphere data, different keyword combos etc...
FAN or BALL AND STICK Plot testing:
This tests the new geographic plotting and geomagnetic plotting defaults and zoom features
FOV plot testing:
This feature was specifically requested for plotting the new NSSC radars, so here is an example of doing jsut that in magnetic MLT coordinates.
GRID plotting:
Map plots only use the Polar projection.