Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pause/Resume test case refactor #796

Closed
wants to merge 6 commits into from
Closed

Pause/Resume test case refactor #796

wants to merge 6 commits into from

Conversation

jtcooper10
Copy link
Collaborator

@jtcooper10 jtcooper10 commented May 12, 2022 •
edited

Update the test case in test/test_pause_resume.py to be more readable and to include additional solvers. With this PR, test coverage for pause/resume is available and shows that the interrupt feature is working as expected.

Changes

  • Removed delegate script pause_model.py from test suite
  • test_pause_resume.py now executes test simulation in setUpClass method instead of globally
  • test_pause_resume.py supports additional solvers
  • test_pause_resume.py uses subTest() method to delineate solvers
  • test_pause_resume.py resolves python from the current script's executable rather than manually resolving to python3 or python

Fixes

  • Fixed a bug in SSACSolver where it would "fill" the remaining timesteps when interrupted

Closes #714

@jtcooper10 jtcooper10 changed the base branch from main to develop May 12, 2022 21:33
@jtcooper10
Update return code assert in test_pause_resume.py
b4ff4fb
@jtcooper10
Finish test_resume
277e967 
- Marked `test_resume` as an expected failure until refactor is finished
@jtcooper10
Fix interrupt output in SSACSolver
d8d3b70 
- Updated "final output" block to be ignored if interrupted
@jtcooper10
Solver-specific models for test_pause_resume
090d632
@jtcooper10 jtcooper10 linked an issue May 16, 2022 that may be closed by this pull request
We need a signal interrupt unittest #714
Open
@briandrawert briandrawert added this to In-Progress in Release 1.7.0 via automation Jul 6, 2022
@briandrawert briandrawert added this to the 1.6.10 milestone Jul 6, 2022
@BryanRumsey BryanRumsey modified the milestones: 1.7.0, 1.7.1 Aug 9, 2022
@BryanRumsey BryanRumsey removed this from In-Progress in Release 1.7.0 Aug 9, 2022
@BryanRumsey BryanRumsey added this to In-Progress in Release 1.7.1 via automation Aug 9, 2022
@BryanRumsey BryanRumsey moved this from In-Progress to To-Do in Release 1.7.1 Oct 5, 2022
@briandrawert briandrawert modified the milestones: 1.7.1, 1.7.2 Oct 5, 2022
@briandrawert briandrawert added this to In Progress in Release 1.7.2 via automation Oct 5, 2022
@briandrawert briandrawert removed this from To-Do in Release 1.7.1 Oct 5, 2022
@briandrawert briandrawert added the enhancement New feature or request label Oct 5, 2022
Base automatically changed from develop to main October 5, 2022 19:35
@jtcooper10 jtcooper10 closed this Dec 12, 2022
Release 1.7.2 automation moved this from In Progress to Done Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanRumsey BryanRumsey Awaiting requested review from BryanRumsey

@briandrawert briandrawert Awaiting requested review from briandrawert

Assignees

@jtcooper10 jtcooper10

Labels
enhancement New feature or request
Projects
No open projects
Release 1.7.2
  
Done
Milestone
1.7.2 Release
Development

Successfully merging this pull request may close these issues.

We need a signal interrupt unittest
3 participants
@jtcooper10 @briandrawert @BryanRumsey