fix (french): replace ${\d} delimiter with #{\d} to resolve currency bugs #202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug that occurs with french sometimes where the delimiter we use accidentally gets malformed so that the $ follows afterwards. This happens because in french (and some other languages) instead of showing a currency like
$20.00
we show it as20,00$
and so Google is taking our${0}
values and trying to be helpful by making these {0}$. Instead we change the symbol to#{0}
which is ignored.Resolves #201
@Stichoza