keycodes

[spatialfree]

i took a stab at an issue i posted a while back: #486

and the following commit actually manages to do what i need for linux ^-^ ...but windows scan codes are different than x11's keycodes~ so that will need to be handled properly before merging these changes!

[maluoi]

Heyas, thanks for the PR here! I'm still thinking about this, but the shape of the API changes here don't feel right to me. This is mixing together the scan codes with the virtual key codes, when they're two rather separate ideas. Like, injecting a scan code should automatically inject the matching virtual key, and injecting a virtual key should automatically inject a scan code as well. Testing for a key should likewise be separate from testing for a scan code.

There may also need to be matching utility functions for users to convert to and from scan codes and virtual keys.

I'm also not terribly excited about using numbers for scan codes? While I understand that scan codes may not have good mappings to real names, it still feels like a really bad experience. Perhaps scan codes can be numbers, or an enumeration that maps QWERTY to scan codes?

On the technical side, a uint8_t would match a byte in C#.

[spatialfree]

thanks for being so thorough! as it really helped me iterate on this~ a whole lot quicker! 👍

i made what seemed like some good tradeoffs of complexity clarity and ease of use inline with your feedback while also making it easier to plug in the windows platform side of things