Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed listview example #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enthus1ast
Copy link

No description provided.

@StefanSalewski
Copy link
Owner

Seems that you only have removed the modulename prefix for 3 proc calls?

I can confirm that your changes compile fine with latest devil compiler.

But I assume that I added the modulename prefix by intent some years ago. Can you remember why I did it? And are you sure that your patch works with all Nim compiler versions still in use?

I will add your fix then for the next release.

@Dankr4d
Copy link

Dankr4d commented Jun 17, 2019

This is not a modulename as it is not a variable name. With those listview prefixes the example cannot be compiled.

@StefanSalewski
Copy link
Owner

listview.nim in the name of the example file, so listview. has been the module name -- we use full qualified name for the involved procs. I did that not for fun, the connect() macro was not working without that long time ago. I asked that time if there is some magic thisModule.myproc() available, so that no code change is needed when module is renamed. Was not available, I would like that.

I am going to remove these qualifiers soon, Nim v.0.20 seems to work fine without.

Have just shipped new release to github, GAction example added. Will ship version 0.5 soon, that release will support GTK4, but will need compiler v0.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants