Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Warn users on possible risks on installing third party unvetted plugins #600

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

RodoMa92
Copy link
Contributor

Please tick as appropriate:

  • I have tested this code on a steam deck or on a PC
  • My changes generate no new errors/warnings
  • This is a bugfix/hotfix
  • This is a new feature

Description

This PR implements proper warning messages for third party install outside our store to warn users of potential malicious code outside our ecosystem.

@RodoMa92 RodoMa92 changed the title Warn third party Warn users on possible risks on installing third party unvetted plugins Mar 13, 2024
@RodoMa92 RodoMa92 changed the title Warn users on possible risks on installing third party unvetted plugins [Feature] Warn users on possible risks on installing third party unvetted plugins Mar 13, 2024
Copy link
Member

@JohnnyCrazy JohnnyCrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

I think the TranslationHelper might be doing too much tho and grow into oblivion, maybe separate functions/helpers in the components would be better in the long term.

Copy link
Member

@EMERALD0874 EMERALD0874 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some non-blocking requested changes regarding the language, but the code changes look great!

backend/locales/en-US.json Outdated Show resolved Hide resolved
backend/locales/en-US.json Outdated Show resolved Hide resolved
backend/locales/en-US.json Outdated Show resolved Hide resolved
backend/locales/en-US.json Outdated Show resolved Hide resolved
backend/locales/en-US.json Outdated Show resolved Hide resolved
@RodoMa92
Copy link
Contributor Author

Nice, LGTM!

I think the TranslationHelper might be doing too much tho and grow into oblivion, maybe separate functions/helpers in the components would be better in the long term.

Yeah, I agree, I just need to find a decent place to place them without adding too much clutter in the structure of the project. I'll probably do this not too far down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants