-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Warn users on possible risks on installing third party unvetted plugins #600
base: main
Are you sure you want to change the base?
Conversation
…party repositories and plugins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
I think the TranslationHelper
might be doing too much tho and grow into oblivion, maybe separate functions/helpers in the components would be better in the long term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some non-blocking requested changes regarding the language, but the code changes look great!
Yeah, I agree, I just need to find a decent place to place them without adding too much clutter in the structure of the project. I'll probably do this not too far down the line. |
Please tick as appropriate:
Description
This PR implements proper warning messages for third party install outside our store to warn users of potential malicious code outside our ecosystem.