Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui-plugin improvment: group generated images by prompt, lora/hypernetworks/embedding support #70

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jtydhr88
Copy link
Contributor

previously, only create one group for all generated images.
However they should be grouped by prompt:
image

@jtydhr88 jtydhr88 changed the title webui-plugin: group generated images by prompt webui-plugin improvment: group generated images by prompt, lora/hypernetworks/embedding support May 25, 2023
@jtydhr88
Copy link
Contributor Author

jtydhr88 commented May 25, 2023

Regarding extra network, I am using style to place the list, I am not sure it is the right place.

About LoRA, currently this is a bug in webui with api mode, see more detail here: AUTOMATIC1111/stable-diffusion-webui#9274, until today, this issue still does not get fixed, that means, if the user want to apply LoRA, they have to mofidy webui.py by theirselves:
modules.script_callbacks.before_ui_callback()
image

@jtydhr88 jtydhr88 force-pushed the webui-plugin-group-generated-images branch from 9b85c08 to 36a33b9 Compare May 25, 2023 17:44
@harrywang
Copy link

Thanks for working on this - looking forward to test this out.

@jtydhr88
Copy link
Contributor Author

jtydhr88 commented May 28, 2023

update, a1111 updated webui to latest 1.3.0, which fixed the lora api issue, the list of loras api provided by default now, no need to change source code

@harrywang
Copy link

harrywang commented Jun 2, 2023

@jtydhr88 how can we use lora? use the <lora:lora_name:0.8> syntax? I don't see a place to see the lora models in the frontend. Thanks!

@jtydhr88
Copy link
Contributor Author

jtydhr88 commented Jun 3, 2023

Hey @harrywang you can go to settings, and choose style type from lora or hypernetwork, then you can go back and choose your Lora from style drop-down, currently I am using the style as Lora holder, I am not sure it is right place, and it only support to select one Lora at once time. If we want support multi-extras, we have to change StableStudio deep code. Right now I hardcode the weight to 1, we may need a slider to allow to change weight to other value. This PR is still pending for review.

@harrywang
Copy link

Hey @harrywang you can go to settings, and choose style type from lora or hypernetwork, then you can go back and choose your Lora from style drop-down, currently I am using the style as Lora holder, I am not sure it is right place, and it only support to select one Lora at once time. If we want support multi-extras, we have to change StableStudio deep code. Right now I hardcode the weight to 1, we may need a slider to allow to change weight to other value. This PR is still pending for review.

Thanks a lot! This is a great starting point for using lora - we will need to able to adjust weights and use multiple loras eventully :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants