Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding kaptive version 3.0.0b1 #950

Closed
wants to merge 2 commits into from
Closed

adding kaptive version 3.0.0b1 #950

wants to merge 2 commits into from

Conversation

erinyoung
Copy link
Contributor

@erinyoung erinyoung commented Apr 9, 2024

There's a new version of kaptive!

I think it's mainly for documentation changes (https://github.com/klebgenomics/Kaptive/releases/tag/v2.0.9)

I just copied 2.0.8 and changed the software version arg.

Update 2024-05-14
Since version 3.0.0b1 came out, I've decided to skip 2.0.9. Version 3.0.0 is very different from prior versions.

This is now ready for review.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung erinyoung marked this pull request as draft April 16, 2024 23:06
@erinyoung
Copy link
Contributor Author

Converting to draft because Kaptive version 3.0 came out

@erinyoung erinyoung changed the title adding kaptive version 2.0.9 adding kaptive version 3.0.0b1 May 14, 2024
@erinyoung
Copy link
Contributor Author

There are quite a few changes with this new version.

  1. The Vibrio database from https://github.com/aldertzomer/vibrio_parahaemolyticus_genomoserotyping is no longer compatible, which is actually why I was using kaptive, so this makes me very sad
    • The lines for this database are still included, they are just commented out with the hope that they'll be included again later
  2. The dependencies have changed. blast is no longer needed, but minimap2 is (not listed anywhere)
  3. Requires python version 3.9 or higher, so I changed the base image to 3.9-slim
  4. The executable has changed
  5. How the executable is used has changed

I've updated the tool-specific readme to reflect these changes.

@erinyoung erinyoung marked this pull request as ready for review May 14, 2024 21:35
@erinyoung
Copy link
Contributor Author

Closing this PR until the Vibrio database is updated

@erinyoung erinyoung closed this May 21, 2024
@erinyoung erinyoung deleted the erin-kaptive branch May 22, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant