Fix relative paths on Windows #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is similar to this pull request... just without an added dependency and using Node's |
|
Awesome! At the moment I've had to add additional tasks to my webpack config in order to work around problems with |
georgezzhang
added a commit
that referenced
this pull request
Jan 10, 2022
[] Lock colors version to 1.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stepping through the code, the issue comes from glob returning filepaths with forward slashes while everything else returns Windows-style backslashes. Normally, node is pretty good at handling these differences but someone was trying to just do a quick string replace instead of using
path.relative().