Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the EOL option from settings and pass it to the IndentProcessingWriter decorator. #2704

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

minidfx
Copy link

@minidfx minidfx commented Apr 13, 2023

This PR gives the opportunity to set the EOL of the code behind generated from the feature files. This is helpful for teams working on different operation system but on the same project by settings for instance CRLF as EOL even for the Mac/Linux users.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • Other (docs, build config, etc)

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@minidfx minidfx force-pushed the feature/eol-options branch 3 times, most recently from d827003 to 98cc030 Compare April 14, 2023 07:14
@minidfx minidfx marked this pull request as ready for review April 14, 2023 07:57
@minidfx minidfx changed the title eol-options: Read the options from settings and pass the EOL into the… Read the EOL option from settings and pass it into the IndentProcessingWriter decorator. Apr 14, 2023
@minidfx minidfx changed the title Read the EOL option from settings and pass it into the IndentProcessingWriter decorator. Read the EOL option from settings and pass it to the IndentProcessingWriter decorator. Apr 14, 2023
@minidfx minidfx force-pushed the feature/eol-options branch 7 times, most recently from 3be6da6 to 73e6a4a Compare April 27, 2023 06:25
@minidfx
Copy link
Author

minidfx commented Apr 27, 2023

Question ... Do you have a specific branch If I would like to add the feature into the current release SpecFlow package (3.9.*) instead of in the master branch which is a beta?

Burgy Benjamin added 3 commits April 27, 2023 08:45
… IndentProcessingWriter decorator.

squash! eol-options: Read the options from settings and pass the EOL into the IndentProcessingWriter decorator.

squash! eol-options: Read the options from settings and pass the EOL into the IndentProcessingWriter decorator.
squash! eol-options: Add the unit tests for the EOL setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant