introduce a TraceListener for MSBuild Task (#2590)

* add MSBuildTraceListener * remove output in container creator * fix output & tests
SpecFlowOSS · May 2, 2022 · db38782 · db38782
1 parent 256d2c6
commit db38782
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/SpecFlow.Tools.MsBuild.Generation/MSBuildTraceListener.cs b/SpecFlow.Tools.MsBuild.Generation/MSBuildTraceListener.cs
@@ -0,0 +1,25 @@
+using Microsoft.Build.Framework;
+using Microsoft.Build.Utilities;
+using TechTalk.SpecFlow.Tracing;
+
+namespace SpecFlow.Tools.MsBuild.Generation;
+
+public class MSBuildTraceListener : ITraceListener
+{
+    private readonly TaskLoggingHelper _taskLoggingHelper;
+
+    public MSBuildTraceListener(TaskLoggingHelper taskLoggingHelper) 
+    {
+        _taskLoggingHelper = taskLoggingHelper;
+    }
+
+    public void WriteTestOutput(string message)
+    {
+        _taskLoggingHelper.LogMessage(MessageImportance.High, message);
+    }
+
+    public void WriteToolOutput(string message)
+    {
+        _taskLoggingHelper.LogMessage(MessageImportance.High, "-> " + message);
+    }
+}
diff --git a/SpecFlow.Tools.MsBuild.Generation/WrappedGeneratorContainerBuilder.cs b/SpecFlow.Tools.MsBuild.Generation/WrappedGeneratorContainerBuilder.cs
@@ -1,8 +1,10 @@
 using System.Collections.Generic;
 using BoDi;
 using TechTalk.SpecFlow.Analytics;
+using TechTalk.SpecFlow.Configuration;
 using TechTalk.SpecFlow.Generator;
 using TechTalk.SpecFlow.Generator.Interfaces;
+using TechTalk.SpecFlow.Tracing;
 
 namespace SpecFlow.Tools.MsBuild.Generation
 {
@@ -27,6 +29,7 @@ public WrappedGeneratorContainerBuilder(GeneratorContainerBuilder generatorConta
 
             objectContainer.RegisterTypeAs<ProjectCodeBehindGenerator, IProjectCodeBehindGenerator>();
             objectContainer.RegisterTypeAs<AnalyticsEventProvider, IAnalyticsEventProvider>();
+            objectContainer.RegisterTypeAs<MSBuildTraceListener, ITraceListener>();
 
             if (_generateFeatureFileCodeBehindTaskConfiguration.OverrideFeatureFileCodeBehindGenerator is null)
             {
@@ -37,6 +40,8 @@ public WrappedGeneratorContainerBuilder(GeneratorContainerBuilder generatorConta
                 objectContainer.RegisterInstanceAs(_generateFeatureFileCodeBehindTaskConfiguration.OverrideFeatureFileCodeBehindGenerator);
             }
 
+            objectContainer.Resolve<IConfigurationLoader>().TraceConfigSource(objectContainer.Resolve<ITraceListener>(), objectContainer.Resolve<SpecFlowConfiguration>());
+
             return objectContainer;
         }
     }

diff --git a/TechTalk.SpecFlow.Generator/GeneratorContainerBuilder.cs b/TechTalk.SpecFlow.Generator/GeneratorContainerBuilder.cs
@@ -58,7 +58,7 @@ public IObjectContainer CreateContainer(SpecFlowConfigurationHolder configuratio
 
             generatorPluginEvents.RaiseCustomizeDependencies(container, specFlowConfiguration);
 
-            container.Resolve<IConfigurationLoader>().TraceConfigSource(container.Resolve<ITraceListener>(), specFlowConfiguration.SpecFlowConfiguration);
+            //container.Resolve<IConfigurationLoader>().TraceConfigSource(container.Resolve<ITraceListener>(), specFlowConfiguration.SpecFlowConfiguration);
 
             return container;
         }