Fix Nether and End portals for non-player entities #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved changeDimension from ServerLevel tick thread to main tick thread.
|
Instead of creating a new patch, it would be better to amend the It would also be nice to see how Folia handles entity teleport between worlds, iirc Folia completly changes how portal teleports work but yeah, another fix is to just schedule entity moves to be handled after the worlds are ticked. |
|
Hello. When will this be resolved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix problems with non-player entities and portals cause some will need this functionallity on their server (like we're).
The main problem I found that teleportation ticked on ServerLevel tick thread but entities neeed to check Poi in another world. I use taskScheduler to schedule changeDimension on main thread.