Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix critical security vulnerabilities #98

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

karlhorky
Copy link

@karlhorky karlhorky commented Jan 31, 2020

Hi there, first of all, thanks for this project! Nice to see work being done in the email ecosystem :)

There are a number of security vulnerabilities in the old dependencies here.

This pull request fixes some of the easier ones (fixed via npm audit fix) and also the critical vulnerability in open.

This is also affecting other projects which depend on heml, such as this one where I have been contributing:

Jinksi/netlify-cms-react-starter#26 (comment)

cc @jgzamora @avigoldman @shrirupa @gfriedmansp @nicklemmon

dependabot bot and others added 18 commits January 31, 2020 10:16
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.4...4.17.13)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.4...4.17.13)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.4...4.17.13)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.4...4.17.13)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.4...4.17.13)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.4...4.17.13)

Signed-off-by: dependabot[bot] <support@github.com>
…/packages/heml-inline/lodash-4.17.13

Bump lodash from 4.17.4 to 4.17.13 in /packages/heml-inline
…/packages/heml-render/lodash-4.17.13

Bump lodash from 4.17.4 to 4.17.13 in /packages/heml-render
…ost#3)

Bump lodash from 4.17.4 to 4.17.13 in /packages/heml-validate
Bump lodash from 4.17.4 to 4.17.13 in /packages/heml-utils
)

Bump lodash from 4.17.4 to 4.17.13 in /packages/heml-styles
Bump lodash from 4.17.4 to 4.17.13 in /packages/heml-parse
Bumps [nwmatcher](https://github.com/dperini/nwmatcher) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/dperini/nwmatcher/releases)
- [Commits](https://github.com/dperini/nwmatcher/commits)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [diff](https://github.com/kpdecker/jsdiff) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/kpdecker/jsdiff/releases)
- [Changelog](https://github.com/kpdecker/jsdiff/blob/master/release-notes.md)
- [Commits](kpdecker/jsdiff@v3.4.0...v3.5.0)

Signed-off-by: dependabot[bot] <support@github.com>
…n/nwmatcher-1.4.4

Bump nwmatcher from 1.4.3 to 1.4.4
Bump diff from 3.4.0 to 3.5.0
@karlhorky
Copy link
Author

Copy link
Contributor

@jgzamora jgzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @karlhorky , LGTM! I'm not super used to working on this project so it might take me a bit to ramp up on the publishing process. Once I figure it out I will merge and publish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants