-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'toHierarchy()' method equivalent to 'toArray()' method #1790
Open
LavaSlider
wants to merge
9
commits into
SortableJS:master
Choose a base branch
from
LavaSlider:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Apr 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0b844ba - Browse repository at this point
Copy the full SHA 0b844baView commit details -
After running 'npm i' and 'npm i npm@latest -g' and
'npm audit fix' and 'npm audit' preparing for building.
Configuration menu - View commit details
-
Copy full SHA for ecaf718 - Browse repository at this point
Copy the full SHA ecaf718View commit details -
Fix various typos that I put in
Such as missing closing parenthases, forgotten commas, wrong assignments, etc.
Configuration menu - View commit details
-
Copy full SHA for ec255eb - Browse repository at this point
Copy the full SHA ec255ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a6a3a1 - Browse repository at this point
Copy the full SHA 6a6a3a1View commit details
Commits on Apr 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for d24451b - Browse repository at this point
Copy the full SHA d24451bView commit details -
Add the 'getHierarch([mode])' method
This method is similar to a recursive 'toString'. It has three modes of operation. Mode 2 is most similar to 'toString' and returns an array of 'id's with interspersed arrays of 'id's for the sublists. The default, mode 0, returns an array of object with 'id' and 'children' properties. Mode 1 is similar to mode 0 except omits the 'children' property if there are no children.
Configuration menu - View commit details
-
Copy full SHA for 42f6c73 - Browse repository at this point
Copy the full SHA 42f6c73View commit details -
Add tests for 'toHierarchy()' for all modes
These tests piggy-back on the already existing 'nested' tests by assessing the output of 'toHierarchy()' after the row-dragging. This is done by adding an 'onEnd' event handler to update the DOM based on current row structure and then compare that text to the expected text.
Configuration menu - View commit details
-
Copy full SHA for da9360c - Browse repository at this point
Copy the full SHA da9360cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 481afc0 - Browse repository at this point
Copy the full SHA 481afc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d2176f - Browse repository at this point
Copy the full SHA 0d2176fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.