Add common test usings to SonarLint.Test.props #5417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgii-borovinskikh-sonarsource
requested review from
pavel-mikula-sonarsource and
vnaskos-sonar
|
pavel-mikula-sonarsource
approved these changes
May 10, 2024
| @@ -26,5 +26,12 @@ | |||
| <PackageReference Include="FluentAssertions" Version="5.9.0" /> | |||
| <PackageReference Include="FluentAssertions.Analyzers" Version="0.11.4" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
There was a problem hiding this comment.
For the entire project (production + test code), we have also this:
https://github.com/SonarSource/sonar-dotnet/blob/3622c4a4126173fd74812d205e4e490fbddb548a/analyzers/Analyzers.targets#L16-L24
Can you add it too, maybe in a separate PR? All except the immutable collections seems relevant in SL project
There was a problem hiding this comment.
The least used is System.Diagnostics. The purpose of this one is to be able easily do Debugger.Break() or Debugger.Launch anywhere
There was a problem hiding this comment.
georgii-borovinskikh-sonarsource
merged commit 0f2727c
into
feature/hardening-may-2024
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5396