Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature to report unknown rules / warnings #2606

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jenspopp
Copy link

@jenspopp jenspopp commented Jan 8, 2024

This is a fix for #2586

I tested it with gcc, cppcheck and clangtidy.

Open points:

  1. Default unknown rule is right now only for the tested frameworks in the xml definitions
  2. We could use protobuf instead of json (but at least for my local use case it was so fast, that I didn't see a reason to invest time here)
  3. In the long run we might need to replace all "-" with "_" in the rule ids.... (due to sonar community changes)
  4. I'm not sure, I covered all possible exceptions (e.g. with login/authentication); but they should occur already before the cxx plugin
  5. Right now only login with token is supported

This change is Reviewable

@guwirth
Copy link
Collaborator

guwirth commented Jan 13, 2024

Hi @jenspopp,

thanks for providing this I will have a look to it.

Regards,

Increase count for rules for CLANGTIDY, CPPCHECK and GCC to account
for new "unknown" rule
Increase count of possible properties to account for
sonar.cxx.unknown.rule.id
@guwirth
Copy link
Collaborator

guwirth commented Feb 2, 2024

@jenspopp thx for fixing the tests

@jenspopp
Copy link
Author

jenspopp commented Feb 5, 2024

@jenspopp thx for fixing the tests

Hi, please note that some tests will fail with Java 17 due to some Exception changes in 17....

@guwirth guwirth added this to the 2.2.0 milestone Feb 7, 2024
@guwirth
Copy link
Collaborator

guwirth commented Feb 7, 2024

Risk too high to add this to V2.1 version,will be merged into V2.2 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants