Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue that print host and webui settings are not properly reset #4734

Merged
merged 1 commit into from Mar 28, 2024
Merged

Fix issue that print host and webui settings are not properly reset #4734

merged 1 commit into from Mar 28, 2024

Conversation

Noisyfox
Copy link
Collaborator

after switching from certain host type

@Noisyfox Noisyfox added the bug Something isn't working label Mar 27, 2024
@SoftFever
Copy link
Owner

@Noisyfox
How to reproduce the bug?

@Noisyfox
Copy link
Collaborator Author

Noisyfox commented Mar 27, 2024 •
edited

  1. Switch the print host to obico/prusa connect/simplyprint (and enter API key if needed), leave the default api url option and save
  2. Go to device tab to make sure the target web page has been loaded
  3. Switch the print host to octo etc. that does not come with a default url, and the url & webui field shoud appears to be cleared, then save
  4. Go to device tab, and you will notice that the obico/prusa connect/simplyprint web page is still loaded, even after restarting the app

@Noisyfox
Copy link
Collaborator Author

print_host_url

@SoftFever
Copy link
Owner

Thanks!

SoftFever
SoftFever approved these changes Mar 28, 2024
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoftFever SoftFever merged commit f36c223 into SoftFever:main Mar 28, 2024
12 checks passed
@Noisyfox Noisyfox deleted the bugfox/printhost-url-reset branch March 28, 2024 23:44
SoftFever pushed a commit that referenced this pull request Apr 13, 2024
@Noisyfox @SoftFever
Fix issue that print host and webui settings are not properly reset (#…
e75a2f8 
…4734)

Fix issue that print host and webui settings are not properly reset after switching from certain host type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoftFever SoftFever SoftFever approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Noisyfox @SoftFever