Small change on Toolbar order #4581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 tasks
SoftFever
approved these changes
Apr 10, 2024
powpingdone
pushed a commit
to powpingdone/OrcaSlicer
that referenced
this pull request
Apr 10, 2024
* Update GLGizmosManager.cpp * Update GLGizmosManager.hpp
powpingdone
pushed a commit
to powpingdone/OrcaSlicer
that referenced
this pull request
Apr 11, 2024
* Update GLGizmosManager.cpp * Update GLGizmosManager.hpp
|
@Noisyfox @SoftFever is this change work as expected? emboss not opening on my design branch |
|
|
|
@Noisyfox interesting. everything works as expected if i switch back to old layout. i can open emboss from context menu but not from toolbar |
|
@Noisyfox after making a change on GLGizmoEmboss.cpp it fixed itself without reason. i guess it was related with visual studio quirks |
SoftFever
pushed a commit
that referenced
this pull request
Apr 13, 2024
* Update GLGizmosManager.cpp * Update GLGizmosManager.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved Emboss icon to next of Color paint
Currently Emboss placed between paint functions
@Noisyfox pointed reordering of all toolbar buttons requires major changes on code. so this small change will give a nice improvement for now
@Noisyfox guided which lines to change. i'm not experienced on C or rebuilding from source. not sure this commit has any problems
Here is current status how they look with new icons. wanted to group paint functions
