Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting to use Django's cache #430

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Setting to use Django's cache #430

wants to merge 2 commits into from

Conversation

mitchelljkotler
Copy link

This is to address #342, caching source and thumbnail models in Django's cache in order to avoid excessive SQL queries.

@jrief
Copy link
Collaborator

jrief commented Sep 15, 2017

Thanks for this pull request, but no unit tests are provided. Please add them before approving it.

jrief
jrief requested changes Oct 31, 2017
View reviewed changes
Copy link
Collaborator

@jrief jrief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request adds additional complexity.
Without a unit test covering this code, it won't be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrief jrief jrief requested changes

Assignees
No one assigned
Labels
needs tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mitchelljkotler @jrief