add untouched analyzer for text promo rules & exact match rule conditions #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e "is" and "is not" for rule conditions
This was referenced Mar 25, 2024
…e "is" and "is not" for rule conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I already have an open pull request and an open issue, but since they are related here is a combined one.
When having a text attribute which is only used for promo rules there is no exact match possible. I use it in a custom collection ['eq' => '..'] and in promo rules via admin.
By default it is not possible do use a rule condition "is" or "is not" .. so I added these two. To make it work I added an untouched analyzer if used in promo rules is enabled.
#3168
#3171
Regards
Marcus