Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #3038 Use display_pattern on product view, product compare pages #3062

Draft
wants to merge 1 commit into
base: 2.10.x
Choose a base branch
from

Conversation

rbayet
Copy link
Collaborator

@rbayet rbayet commented Sep 25, 2023

(disabled by default)

@rbayet
Copy link
Collaborator Author

rbayet commented Sep 25, 2023

Comment copy/pasted from #3047 (comment)

Hello @ecrocombe @vahonc

Actually, testing the feature locally, I think it needs a bit more polish : the precision is actually not taken into account at all.

It seems that the slider cheats by systematically using the JS price formatter because the locale oriented PHP classes of Magento2 Framework does not seem to really care about it (hence probably because you went for "round").
I've tried using the approach of \Smile\ElasticsuiteCatalog\Model\Layer\Filter\Decimal::formatValue but that does not work either.

So I'll try to figure out a way to correctly have the value formatted exactly like in the slider.
@vahonc Could you look into it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of product attribute's display_pattern on product view page
2 participants