Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FloorMarker emits a weak redstone signal when elevator is at selected floor. #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smbarbour
Copy link

This change, if you choose to accept it, will cause the FloorMarker block to output a fairly weak signal when the elevator arrives at a floor. This signal is sufficient to open a door and will cease when the elevator departs (closing the door). It would also be able to light a redstone lamp and/or trigger a noteblock, thereby signalling the arrival of the elevator.

@smbarbour
Copy link
Author

One minor issue with this is that some things, like adjacent redstone, will cause it to not respond to a button click on the first try.

@Eurymachus
Copy link
Member

I don't think Tarig wants to allow floor marker to output signal as we'll be allowing other forms displaying arrival at floor. Especially if it's buggy :p

@smbarbour
Copy link
Author

I figured it was less likely to be accepted, hence why I split them into two PRs. The goofy behavior is likely due to being a block that both receives and emits a signal. One thing to note, if and when a separate block is made for detecting the presence of an elevator, canProvidePower needs to return true to make it control an adjacent door.

@Tarig0
Copy link
Member

Tarig0 commented Nov 18, 2014

If I fix the issue you've witnessed with the Redstone camo would this still be a necessary feature? Keep in mind the elevator doesn't have to be a single platform

@Tarig0
Copy link
Member

Tarig0 commented Nov 18, 2014

Actually comparator's will fix the odd behavior

@smbarbour
Copy link
Author

It can be done using camo redstone blocks, though it would trigger when an elevator passes by as well and requires additional space to hide wiring, but I can definitely get behind a separate elevator detection block.

@Dushess
Copy link

Dushess commented Sep 25, 2016

I thought about other method, but don't know can it be realised?
So, FloorMarker uses CommandBlock's method instead of emitting weak RS signal. (activate block by coordinates from yourself, yes we need to enter coord. shift somewhere)
It will hold the door by 5 seconds, and will be triggered by elevator arrival and by button press(on FM)
Or maybe elevator blocks can provede that (they can transfer RS signal to nearby blocks, some of them will be under the door, and then that blocks will power on the door, ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants