-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS app naming improvements #991
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SlimeVR Server is not the GUI, and the app is specifically the GUI
Please change it to SlimeVR
Okay, but the windows installer installs a “SlimeVR Server” shortcut into start menu that launches the GUI, so I wonder why is it not appropriate here? It’s the name for the package that contains both GUI and server. |
And we also have the linux desktop file which is just I don't really know the reason for why it's called |
4c9c754
to
2d4c5a9
Compare
why are you signing the app |
Do you not want that? I was just about to say I added that because without a signature users are probably going to have problems launching the app because macOS Gatekeeper is only getting stricter. |
I mean, we don't have any signature to sign it with XD. Or does every macOS come with a user signature? |
I signed with Also idealy version of the app bundle should match github releases, right now I believe it's inherting the GUI version. Do you want that to be overwritten in Info.plist as well? |
then its fine to sign it. the version stuff, it would be nice to fix the actual issue, the |
It's possible with |
I kinda figured it out. Workflows triggered by releases will have their version in |
b4f0b8b
to
a1b0cc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's leave this for another PR
a1b0cc3
to
2d4c5a9
Compare
Sets "SlimeVR" as app name in multiple locations. In the future this could be replaced by
displayName
if tauri ever implement it.