Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS app naming improvements #991

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

i0ntempest
Copy link

@i0ntempest i0ntempest commented Apr 14, 2024

Sets "SlimeVR" as app name in multiple locations. In the future this could be replaced by displayName if tauri ever implement it.

Copy link
Member

@ImUrX ImUrX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SlimeVR Server is not the GUI, and the app is specifically the GUI

Please change it to SlimeVR

@ImUrX ImUrX added Area: Continuous Integration Automated testing and deployment Type: Enhancement Adds or improves a feature OS: macOS Operating system: macOS labels Apr 14, 2024
@i0ntempest
Copy link
Author

The SlimeVR Server is not the GUI, and the app is specifically the GUI

Okay, but the windows installer installs a “SlimeVR Server” shortcut into start menu that launches the GUI, so I wonder why is it not appropriate here? It’s the name for the package that contains both GUI and server.

@ImUrX
Copy link
Member

ImUrX commented Apr 14, 2024

And we also have the linux desktop file which is just SlimeVR, we have the binary called slimevr.exe in Windows, and we have the macOS binary which is slimevr.app

I don't really know the reason for why it's called SlimeVR Server in the start menu but I suspect it's been like that since the start and having to change it seems like too much problem.

@ImUrX
Copy link
Member

ImUrX commented Apr 14, 2024

why are you signing the app

@i0ntempest
Copy link
Author

why are you signing the app

Do you not want that? I was just about to say I added that because without a signature users are probably going to have problems launching the app because macOS Gatekeeper is only getting stricter.

@ImUrX
Copy link
Member

ImUrX commented Apr 14, 2024

I mean, we don't have any signature to sign it with XD. Or does every macOS come with a user signature?

@i0ntempest
Copy link
Author

I mean, we don't have any signature to sign it with XD. Or does every macOS come with a user signature?

I signed with - identity which is local adhoc signature. It's not a developer identity but should be better than flat out no signature.

Also idealy version of the app bundle should match github releases, right now I believe it's inherting the GUI version. Do you want that to be overwritten in Info.plist as well?

@ImUrX
Copy link
Member

ImUrX commented Apr 14, 2024

then its fine to sign it.

the version stuff, it would be nice to fix the actual issue, the package.json of gui is not the same as the git tag and i don't really know how to fix it

@i0ntempest
Copy link
Author

the version stuff, it would be nice to fix the actual issue, the package.json of gui is not the same as the git tag and i don't really know how to fix it

It's possible with npm version, but it's usually used to create/manage git tags, not the other way around (following existing git tags). I'm experimenting with it now, there should be a way around.

@i0ntempest
Copy link
Author

i0ntempest commented Apr 15, 2024

I kinda figured it out. Workflows triggered by releases will have their version in gui/packages.json corrected but that will also make the build dirty. To truely get around this I guess you really need to use npm version the way it meant to be used.
Edit: I think I have a near perfect solution now. No dirty builds anymore.

@i0ntempest i0ntempest force-pushed the macos-workflow-raw branch 3 times, most recently from b4f0b8b to a1b0cc3 Compare April 15, 2024 06:47
Copy link
Member

@ImUrX ImUrX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's leave this for another PR

.github/workflows/gradle.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Continuous Integration Automated testing and deployment OS: macOS Operating system: macOS Type: Enhancement Adds or improves a feature
Development

Successfully merging this pull request may close these issues.

None yet

2 participants