Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing head tracker status #962

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add missing head tracker status #962

wants to merge 9 commits into from
+102 −9

Conversation

ImUrX
Copy link
Member

@ImUrX ImUrX commented Mar 18, 2024 •
edited

  • adds isHmd flag in Tracker
  • make an error when there is available isHmd trackers and headTracker in main skeleton is null
  • require reset on all assigned trackers when the HumanSkeleton#headTracker has changed

@ImUrX ImUrX added Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature Area: Server Related to the server labels Mar 18, 2024
@ImUrX ImUrX marked this pull request as ready for review March 30, 2024 17:06
@ImUrX ImUrX added the Status: Blocked by other issue Progress cannot be made until linked issue is resolved label Mar 30, 2024
@ImUrX
Copy link
Member Author

ImUrX commented Mar 30, 2024

Haven't tested it yet!

@ImUrX
Copy link
Member Author

ImUrX commented Mar 31, 2024

i tested it and it seems to work, status system is a little finicky in the GUI side, sometimes packets are lost, it should be solved someday tbh

@ImUrX ImUrX removed the Status: Blocked by other issue Progress cannot be made until linked issue is resolved label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ButterscotchV ButterscotchV Awaiting requested review from ButterscotchV ButterscotchV is a code owner

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

@Erimelowo Erimelowo Awaiting requested review from Erimelowo Erimelowo is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area: GUI Related to the GUI Area: Server Related to the server Type: Enhancement Adds or improves a feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ImUrX