COMP: Make EditorEffects base classes available for extensions #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlicerMacroBuildModuleQtLibrary macro does not add module include directories to CMake variables that are exposed to extensions. However, we need Segmentations/EditorEffects classes to be available for extensions to allow creating editor effects in C++.
|
@jcfr is there any drawback of using SlicerMacroBuildModuleWidgets macro for exposing Segment Editor effects C++ base classes to extensions? Do you have any alternative suggestions? We used SlicerMacroBuildModuleQtLibrary before but that did not make these classes available for extensions. |
|
@jcfr can you have a look? Just tell me if it's OK to use the macro like this. Thanks! |
|
I don't foresee any issues. That said, I suggest we introduce a new CMake function called And as discussed, a new module template should be added. |
|
@lassoan Can this be merged as is with the new macro added later? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SlicerMacroBuildModuleQtLibrary macro does not add module include directories to CMake variables that are exposed to extensions. However, we need Segmentations/EditorEffects classes to be available for extensions to allow creating editor effects in C++.
See background in https://discourse.slicer.org/t/unable-to-include-qslicersegmentationseditoreffects-when-building-extension/9371/5