Removed PassengerUtils class and replaced methods in referencing classes #6693
+120
−248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
approved these changes
May 13, 2024
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Moderocky
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the PassengerUtils class, and replaced all the uses of its methods. Changed the ExprPassenger expression to be a PropertyExpression rather than a SimpleExpression too. Did some testing to ensure everything was still working and it all seemed to be in check, but wouldn't mind a second look through to make sure.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6676 #6641