Support for LogLevel in EffLog

[EquipableMC]

Description

Added ways to declare severity when logging

---

Target Minecraft Versions: any
Requirements: none
Related Issues: none

[Fusezion]

I'll have more probably just for now here's this

[Fusezion]

More changes near you. Let's update the #toString(Event e, boolean debug) while we're here, to include severity tags

[sovdeeth]

Also, have you actually tested this? I'd like to see a screenshot of the output.

[sovdeeth]

adding breaking changes due to adding INFO to the output by default.

[EquipableMC]

Also, have you actually tested this? I'd like to see a screenshot of the output.

I have not

[Fusezion]

adding breaking changes due to adding INFO to the output by default.

Sorry but how does this apply a breaking change? Very confused there.

[EquipableMC]

Also, have you actually tested this? I'd like to see a screenshot of the output.

I have not

Okay now I have

[sovdeeth]

Also, have you actually tested this? I'd like to see a screenshot of the output.

I have not

Okay now I have

I'm mainly concerned about the other severities in console

[EquipableMC]

Also, have you actually tested this? I'd like to see a screenshot of the output.

I have not

Okay now I have

I'm mainly concerned about the other severities in console

I don't know why exactly warning/severe has a tab

[Fusezion]

alright so let's do an actual test equip

on load:
    log "info"
    log "warning" with severity of warning
    log "severe" with severity of severe

this should log on reload my guess is severe will not work but info and warning will

[EquipableMC]

alright so let's do an actual test equip

on load:
    log "info"
    log "warning" with severity of warning
    log "severe" with severity of severe

this should log on reload my guess is severe will not work but info and warning will

yeah you're right

[sovdeeth]

This is why I was talking about a RedirectingLogHandler in discord
You'll need it for warning/error.

[sovdeeth]

adding breaking changes due to adding INFO to the output by default.

Sorry but how does this apply a breaking change? Very confused there.

@Fusezion file output would now have an INFO where there was none previously.

[EquipableMC]

alright so let's do an actual test equip

on load:

log "info"

log "warning" with severity of warning

log "severe" with severity of severe

this should log on reload my guess is severe will not work but info and warning will

yeah you're right

Okay so regarding this, this has been fixed.

[Pikachu920]

you can just directly use logLevel as the toString will return the appropriate name. I am also a little concerned about the addition of the severity into the file since it's a breaking change. I think when people specify severity it will be specifically for the console log level because that actually has an impact on things. if they wanted it part of their file message, they could just prepend their message. we could disallow the file/severity combo in init :)

[EquipableMC]

Well log is basically just mimicking the console. It's like sending a message to console but in the form of a log file. so this part "I think when people specify severity it will be specifically for the console log level because that actually has an impact on things." I can see where you are coming from, but that just seems weird in my opinion. "if they wanted it part of their file message, they could just prepend their message. we could disallow the file/severity combo in init" by default this returns INFO but I could just make it not return INFO. This should really be up for discussion in my honest opinion

[sovdeeth]

Yeah I think omitting INFO would be fine, avoids breaking changes

[Pikachu920]

im cool with omitting info.

[Pikachu920]

it may be useful to allow users to specifically request info so the prefix can be used in a consistent manner

[EquipableMC]

I am just going to omit info. Info just seems useless to be honest. I feel like keeping warning and severe is better

[sovdeeth]

Suggested change

	})
	})