Adds Enchantment Glint Syntaxes

[NotSoDelayed]

Description

This PR adds the enchantment glint syntaxes into Skript!

---

Target Minecraft Versions: Minecraft 1.20.5
Requirements: Spigot 1.20.5
Related Issues: none

[sovdeeth]

needs tests

[Fusezion]

Might be worth adding an expression to give with/without enchantment glint

%itemtypes% with[:out] enchantment glint [override]

[NotSoDelayed]

The following will be added in the coming hours:

• Expression to get preset enchantment glint items
• Condition of whether an item has enchantment glint override
• TESTS!!

[Fusezion]

Aside from other requested changes looks fine to me

[APickledWalrus]

It seems unnecessary to me to have an Expression, Condition, and Effect for the same thing. I think we should pick between Condition and Effect versus Expression (I think the former may be preferrable as I am not really a fan of boolean expressions). I'd like to gather some thoughts on this :)

[sovdeeth]

It seems unnecessary to me to have an Expression, Condition, and Effect for the same thing. I think we should pick between Condition and Effect versus Expression (I think the former may be preferrable as I am not really a fan of boolean expressions). I'd like to gather some thoughts on this :)

I'm in agreement, in most cases a condition and effect flow much better. I'm not as opposed to having multiple ways to do the same thing, though, so I'd be ok with leaving the expression in too.

[NotSoDelayed]

It seems unnecessary to me to have an Expression, Condition, and Effect for the same thing. I think we should pick between Condition and Effect versus Expression (I think the former may be preferrable as I am not really a fan of boolean expressions). I'd like to gather some thoughts on this :)

For this case, how about I scrap the condition syntax? As the user can use the expression to check whether the override is set or not.

[APickledWalrus]

I honestly might rather see the expression scrapped, but I'd like opinions from others.

[ShaneBeee]

It seems unnecessary to me to have an Expression, Condition, and Effect for the same thing. I think we should pick between Condition and Effect versus Expression (I think the former may be preferrable as I am not really a fan of boolean expressions). I'd like to gather some thoughts on this :)

me personally I'm the exact opposite.
My main reason for that is I personally prefer 1 syntax (expression) over 2 syntaxes (effect and condition) that basically do the same thing as the expression.
I find that when people ask for help, it's much easier to point them to the docs of one expression vs. 2 docs for effect/condition.
But thats just my opinion.

[APickledWalrus]

I think that's a fair point. More than anything to me, when thinking about the goal of Skript to provide English-like syntax, make the player's tool glint is much better than set the player's tool's enchantment glint to true

the ability to represent it as a boolean can be useful so I wonder if it's time we examine conditions as expressions again