Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies and integrated isEmojiSelected #52

Closed
wants to merge 2 commits into from

Conversation

noctivityinc
Copy link

Updated the dependencies for react-native-gestures and react-native-reanimited and merged in @EugeneKey's changed. Cannot install without updating these dependencies

@aDamNNNN
Copy link

aDamNNNN commented May 8, 2024

@het-a-simform @parth-simform @ravir-simform @virajpsimformsolutions @kuldip-simform can someone please review the pull request so it can be merged? It would be very good if it could work with reanimated version 3

Copy link

@aDamNNNN aDamNNNN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@mukesh-simform
Copy link
Collaborator

@aDamNNNN Currently, we're testing this with the latest reanimated version and validating removal of that emojiAnimatedScaled, after thorough testing we will incorporate these changes and are also aiming for a release soon. Thank you for your contribution and patience @noctivityinc.

@mukesh-simform
Copy link
Collaborator

Removal of emojiAnimatedScaled will impact animation in the reaction popup and also emojiSelectedContainerStyle prop has not been passed from the parent component. We will plan reanimated version update to v3 in a separate pull request so closing this. Feel free to raise an issue if needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants