-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function input feature for time-dependent boundary conditions #108
base: master
Are you sure you want to change the base?
Conversation
Initial implementation of a time-dependent flow BC from an expression string. Currently results in a SEGFAULT.
Finished debugging time-dependent flow block
I ran the
You need to add catching exceptions in the Python testing code. |
|
||
parser_t parser; | ||
|
||
parser.compile(expression_string, expression); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is very easy for a user to add an incorrect math expression so you need to have a try/catch here and also throw an exception if parser.compile()
returns false.
We don't want to mix external software with our source code so the |
Also I see that there is Docker container file in |
Current situation
Closes #89
Release Notes
fn
to flow and pressure boundary conditions that takes in a stringt
t
= the current time value.Documentation
Time-dependent boundary conditions can now be input using a function passed in as a string. The function is of the variable
t
, or time. For example:"bc_values": { "fn": "2.0 * (4*atan(1.)) * COS(2.0 * (4*atan(1.)) * t)" }
Testing
Test case
test_time_dependent_block
added totest_io.py
, which runs json filestimeDep_Flow.json
andtimeDep_Pressure.json
.Code of Conduct & Contributing Guidelines