Fix interfacing with svSolver/svFSI #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
=======================================
Coverage 87.51% 87.52%
=======================================
Files 51 51
Lines 1963 1964 +1
=======================================
+ Hits 1718 1719 +1
Misses 245 245 ☔ View full report in Codecov by Sentry. |
mrp089
requested changes
Feb 15, 2024
mrp089
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
Addresses #101
Release Notes
Main change is a small bug fix here: https://github.com/menon-karthik/svZeroDPlus/blob/fda0da8b371c1122ff6a744b15e8b6f79a64bd4f/src/solve/SimulationParameters.cpp#L361
I also added a new test (
tests/test_interface/test_03) that now makes sure the interface is working correctly for multiple time steps of a coupled 3D solver. The previous tests only tested one time step.Documentation
No major changes to documentation. Just added comments to the interface tests.
Testing
Added a new test case for the interface.
Code of Conduct & Contributing Guidelines