Skip to content
This repository has been archived by the owner on Dec 16, 2023. It is now read-only.

Remove assert causing syntax error. #78

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

ktbolt
Copy link
Contributor

@ktbolt ktbolt commented Oct 2, 2023

@mrp089
Copy link
Member

mrp089 commented Oct 2, 2023

@ktbolt, if you look at the git blame, there was a reason for these asserts (see #74). This error could be triggered by wrong user input, so I don't think it's a good idea to just delete statements that are supposed to catch errors.

Can you throw an error instead if you don't like assert statements?

@ktbolt
Copy link
Contributor Author

ktbolt commented Oct 2, 2023

@mrp089 Asserts are used for testing and not for production. I'll replace them with exceptions.

@ktbolt
Copy link
Contributor Author

ktbolt commented Oct 2, 2023

I've replaced the asserts with exceptions.

Note that asserts are disabled for a Release build so now these checks will cause the code to fail.

@mrp089 mrp089 merged commit ecac577 into SimVascular:master Oct 3, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants