Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High order element face mesh fails 205 #206

Closed

Conversation

ktbolt
Copy link
Collaborator

@ktbolt ktbolt commented Mar 12, 2024

CFD simulations were failing with 10-noded Tets, fixed several bugs. See #205.

The PR has a bit of noise from adding some debugging statements and replacing some incorrect array initialization statements.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 56.30252% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 62.79%. Comparing base (318e3a6) to head (265631b).

❗ Current head 265631b differs from pull request most recent head 420c318. Consider uploading reports for the commit 420c318 to get more accurate results

Files Patch % Lines
Code/Source/svFSI/vtk_xml_parser.cpp 46.06% 48 Missing ⚠️
Code/Source/svFSI/vtk_xml.cpp 60.00% 2 Missing ⚠️
Code/Source/svFSI/fluid.cpp 95.00% 1 Missing ⚠️
Code/Source/svFSI/nn_elem_gnn.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   63.12%   62.79%   -0.34%     
==========================================
  Files         105      103       -2     
  Lines       27424    27213     -211     
==========================================
- Hits        17312    17088     -224     
- Misses      10112    10125      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MatteoSalvador MatteoSalvador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ktbolt, I talked to @wgyang and he will kindly add a new test case to cover these new functions before merging the PR.

@MatteoSalvador
Copy link
Collaborator

MatteoSalvador commented Mar 20, 2024

@wgyang thanks for adding this test! Unfortunately the pipeline is currently failing with the error No module named 'conftest'. I think you should update test_fluid.py again with from .conftest import run_with_reference instead of from conftest import run_with_reference

@wgyang
Copy link
Contributor

wgyang commented Mar 21, 2024

@wgyang thanks for adding this test! Unfortunately the pipeline is currently failing with the error No module named 'conftest'. I think you should update test_fluid.py again with from .conftest import run_with_reference instead of from conftest import run_with_reference

@MatteoSalvador Sorry about that. I will fix it.
Thank you!

wgyang and others added 2 commits March 20, 2024 23:45
@MatteoSalvador
Copy link
Collaborator

MatteoSalvador commented Mar 28, 2024

@wgyang I have changed the workflow for tests on Ubuntu to a Docker-based framework. If you pull the current SimVascular/svFSIplus we should be able to merge this PR as well!

@wgyang
Copy link
Contributor

wgyang commented Mar 28, 2024

@wgyang I have changed the workflow for tests on Ubuntu to a Docker-based framework. If you pull the current SimVascular/svFSIplus we should be able to merge this PR as well!

Thank you @MatteoSalvador! Will do.

wgyang and others added 3 commits March 28, 2024 16:56
Incorporate recent updates on test tolerance and continuous integration
Fix integration test errors
@ktbolt ktbolt closed this Apr 30, 2024
@ktbolt ktbolt deleted the High-order-element-face-mesh-fails_205 branch April 30, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants