Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Commits Daily. #27

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Minimum Commits Daily. #27

wants to merge 4 commits into from

Conversation

0vm
Copy link

@0vm 0vm commented Aug 5, 2023

New Command Line Argument --min_commits:
Added a new optional argument that allows users to specify the minimum number of commits they want the script to make each day. The argument ranges from 1 to 20, with a default value of 1. This additional feature gives users more control over the number of commits made daily.

Update to contributions_per_day function:
The function has been revised to incorporate the new min_commits argument. Now, the number of daily contributions is a random value between min_commits and max_commits (both inclusive). This change enhances the variability and customization of the script's operations.

Edge case handling for min_commits and max_commits:
Added checks to handle scenarios where min_commits may be greater than max_commits. In such cases, the values are swapped to maintain a valid commit range for the script. This is crucial to ensuring the robustness of the script when faced with unusual user inputs.

contribute.py Outdated Show resolved Hide resolved
@0vm
Copy link
Author

0vm commented Aug 9, 2023

build failed due to:
Version 2.7 was not found in the local cache
Error: Version 2.7 with arch x64 not found
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

@Shpota
Copy link
Owner

Shpota commented Aug 10, 2023

I need to take a look at that. Looks like GitHub Actions deprecated some of the APIs. I will fix it and let you know

@Shpota
Copy link
Owner

Shpota commented Aug 11, 2023

@0vm I fixed the build. Could you please sync up your branch with the latest changes?

@Shpota
Copy link
Owner

Shpota commented Aug 11, 2023

There are some linter errors

@0vm
Copy link
Author

0vm commented Aug 22, 2023

so whats the plan

@Shpota
Copy link
Owner

Shpota commented Aug 24, 2023

Thanks @0vm, once the linter issues are fixed I can merge the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants