Add end_date_before arg to the script #22
Conversation
Add "end_days_before" documents
|
Hey @gharghi |
Update instruction of using stat_date and end_date
|
Your comment makes sense. |
| @@ -58,7 +58,16 @@ will keep committing. | |||
| ```sh | |||
| python contribute.py --days_before=10 --days_after=15 | |||
| ``` | |||
| Use `--start_date` to specify start date of commits. This option doesn't work if used with days_before. | |||
There was a problem hiding this comment.
I would propose making them mutually exclusive. If one of them is specified, the script should work. If both are specified, it should show an error.
There was a problem hiding this comment.
It shouldn't.
Imagine you need to set a period of time in last year.
There was a problem hiding this comment.
I mean, if someone uses both --days_before and --start_date this should lead to an error
There was a problem hiding this comment.
It could be. But I thought to make it more error free and handle them in the code.
There was a problem hiding this comment.
I think it is better when the logic is explicit and the user doesn't have to guess what would happen when they specify two parameters that collide
Add feature to specify the finish date before current dats. For example run script from 50 days to 10 days before current date.