Stop validating that returned scope matches requested scope #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've determined that this does not constitute a security issue in Shopify's context and we'd like the flexibility to return a different set of scopes in the future.
ragalie
force-pushed
the
remove-scope-check
branch
from
b7eabc6
to
7d6a2ce
Compare
|
Extra context: Merchants can only grant scopes to an app that they have access to themselves, this means that an account takeover on a merchant account with lower privileges won't result in privilege escalation when installing an app. |
bernardoamc
approved these changes
Jun 16, 2023
arineto
approved these changes
Jun 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've determined that this does not constitute a security issue in Shopify's context and we'd like the flexibility to return a different set of scopes in the future.