Skip to content
This repository has been archived by the owner on Aug 30, 2018. It is now read-only.

Fixed a nav menu draw open, then closed horizontal scroll bug #573

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed a nav menu draw open, then closed horizontal scroll bug #573

wants to merge 3 commits into from

Conversation

MatthewKennedy
Copy link

Prior to bug fix, if you opened the nav menu then closed it without a
page reload, you would find a horizontal scroll on the main page with
overspill to the right hand side.

prior to bug fix, if you opened the nav menu then closed it without a
page reload, you would find a horizontal scroll on the main page with
overspill to the right hand side.
@cshold
Copy link
Contributor

cshold commented Sep 6, 2016

Do you have a link to a shop where we can see the issue? What browser(s) did it happen in?

Adding !important styles like this isn't ideal.

@MatthewKennedy
Copy link
Author

Here is a link to one site with the css fix removed, if you open the menu then open the submit then close the menu you should get a side scroll

On 6 Sep 2016, at 16:35, Carson Shold notifications@github.com wrote:

Do you have a link to a shop where we can see the issue? What browser(s) did it happen in?

Adding !important styles like this isn't ideal.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #573 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ABLuvnxOAMfDgV6s7ysZC3YlG6dRD2ovks5qnYhKgaJpZM4J0h7e.

@MatthewKennedy
Copy link
Author

https://tkastore-2.myshopify.com/pages/about-us

On 6 Sep 2016, at 21:50, Matthew Kennedy m.kennedy@me.com wrote:

Here is a link to one site with the css fix removed, if you open the menu then open the submit then close the menu you should get a side scroll

On 6 Sep 2016, at 16:35, Carson Shold <notifications@github.com mailto:notifications@github.com> wrote:

Do you have a link to a shop where we can see the issue? What browser(s) did it happen in?

Adding !important styles like this isn't ideal.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #573 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ABLuvnxOAMfDgV6s7ysZC3YlG6dRD2ovks5qnYhKgaJpZM4J0h7e.

…hen a submenu is opened extending below the screen.

Common issue can be recreated easily.

Take an iOS touch device, make the navigation so that when the  nav
draw is opened then the submenu is opened it extends past the bottom of
the screen requiring a scroll to see the links, the drawer content
wouldn’t scroll, prior to the css fix.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants