Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Auto flags and added polygonal regions in claim command. Also removed sources from jar #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Qveshn
Copy link

@Qveshn Qveshn commented Oct 27, 2021

Details:

  1. Added version substitute from build.gradle to plugin.yml
  2. Remove sources (java) from jar
  3. clean task now also cleans target dir
  4. Use fake actor to add auto flags to region in claim command
    (Issue: AutoFlags не добавляются во время rg claim, если у игрока нет пермов на них. #22)
  5. Added the ability to claim polygonal regions who have permission "worldguard.region.unlimited" (as WorldGuard does)

…l, improve clean task)

- Remove sources from jar
- Add version substitute in plugin.yml
- Add target dir to clean task
…ve permission for these flags)

- Use fake Actor while adding auto flags in claim command
…guard.region.unlimited"

(as in latest WorldGuard)
@Shevchik
Copy link
Owner

  1. Sources must stay in jar. That's the most correct way of upholding the GPL license terms.
  2. The reason why real actor was implemented is to make actor-aware flags work. So using fully fake actor is not an option, a an actor wrapper must be made, that passes everything to real actor with the exception of permission checks.
  3. Use filesMatching('plugin.yml') { expand 'version': project.version } to substitute version

@Qveshn
Copy link
Author

Qveshn commented Oct 28, 2021

The reason why real actor was implemented is to make actor-aware flags work. So using fully fake actor is not an option, a an actor wrapper must be made, that passes everything to real actor with the exception of permission checks.

"actor-aware flags" - I am not sure I understand this right. =\
Can you give me please the example of such "actor-aware" flag?

Hmm...
As I understood, WorldGuard uses actor only to check permission and send him the message about the added flag. All I wanted to do was remove the permission check and suppress sending a message to the player about the added flag. Suppressing the message - because the original command was /rg claim ... and not /rg flag ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants