Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add word limit #79

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add word limit #79

wants to merge 2 commits into from

Conversation

XJXuan888
Copy link

@XJXuan888 XJXuan888 commented Feb 11, 2024

Add a limit to the number of characters in the user input box for the composer and sheet name in the upload page

Description

Currently, there is no character limit when uploading a sheet and entering the sheet name and composer name. Upon uploading, it obscures the sheet thumbnail as well as the display image of the sheet as the characters just populate the screen.

Fixes # (issue)

Now, an error message is displayed when it hits the character limit and disables users from clicking the next button.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

@vallezw
Copy link
Member

vallezw commented Feb 13, 2024

Hey @XJXuan888, thanks for the PR. Could you maybe upload a demo video? It makes it easier to review. If not it's also fine tell me then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants