Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Implement or stub FontFace interface's attribute getters/setters #24278

Merged
merged 2 commits into from May 11, 2024

Conversation

ADKaster
Copy link
Member

We only support parsing half of these, so the ones we don't recognize
get a friendly exception thrown.

@ADKaster ADKaster requested a review from AtkinsSJ as a code owner May 10, 2024 16:29
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label May 10, 2024
We only support parsing half of these, so the ones we don't recognize
get a friendly exception thrown.
Copy link
Member

@AtkinsSJ AtkinsSJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me! As we discussed, doing this "properly" is going to be significant work so this is fine for now.

@AtkinsSJ AtkinsSJ merged commit 2bc51f0 into SerenityOS:master May 11, 2024
14 of 15 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants